gatekeeper: more preparation for Ubuntu 24.04 LTS #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit avoids the following compilation warning:
lib/rib.c: In function ‘rib_create’:
lib/rib.c:125:15: warning: ‘dummy’ may be used uninitialized [-Wmaybe-uninitialized]
125 | ret = __read_addr(max_length, &dummy, (const uint8_t *)&dummy);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/rib.c:30:1: note: by argument 3 of type ‘const uint8_t *’ {aka ‘const unsigned char *’} to ‘__read_addr’ declared here
30 | __read_addr(uint8_t length, rib_address_t *cpu_addr, const uint8_t *address)
| ^~~~~~~~~~~
lib/rib.c:109:23: note: ‘dummy’ declared here
109 | rib_address_t dummy;
| ^~~~~
Not only does gettid() require #define _GNU_SOURCE, but it has also presented header problems in different versions of Lib C. So this commit eases the effort to compile Gatekeeper on different distros. A small benefit gained from using rte_gettid() is that it caches the thread ID in a per-thread variable to avoid subsequent system calls.
This commit centralizes all RSS fields that need to be set in check_if_rss().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.