Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for re-instantiation, fixing rare eternal loading #2999

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

olemartinorg
Copy link
Contributor

Description

Adding automated tests for re-instantiation. Also removing ref-states and trying to simplify how this works, and making sure to clear an ongoing/failed instantiation when the user leaves the page (such as navigating back to party selection manually) which previously made the app display the loading-spinner indefintely.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Ole Martin Handeland added 2 commits February 11, 2025 17:08
… instantiation when the user moves away from the page (such as when going back to party selection).
@olemartinorg olemartinorg added the kind/bug Something isn't working label Feb 11, 2025
@olemartinorg olemartinorg merged commit d94f4fd into main Feb 12, 2025
15 checks passed
@olemartinorg olemartinorg deleted the fix/reinstantiation-testing branch February 12, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated tests for party selection fix App gets stuck on instantiation after switching party
2 participants