Adding tests for re-instantiation, fixing rare eternal loading #2999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding automated tests for re-instantiation. Also removing ref-states and trying to simplify how this works, and making sure to clear an ongoing/failed instantiation when the user leaves the page (such as navigating back to party selection manually) which previously made the app display the loading-spinner indefintely.
Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping