Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instantiation retry after failed attempt #2985

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

danielskovli
Copy link
Contributor

@danielskovli danielskovli commented Feb 6, 2025

Description

Bug report from service desk: https://github.com/Altinn/altinn-support-private/issues/4002

Slack thread: https://digdir.slack.com/archives/C076GU2QHCG/p1738842092707849

Process

This is a process that doesn't actually exist for us at the moment, but when this fix eventually gets deployed, we need to communicate this issue back to service desk/interested parties.

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@danielskovli danielskovli self-assigned this Feb 6, 2025
@danielskovli danielskovli added the kind/bug Something isn't working label Feb 6, 2025
@danielskovli
Copy link
Contributor Author

danielskovli commented Feb 6, 2025

Needs an automated test for the scenario reported by service desk ticket.

Automatic tests will be added after merge: #2997

@danielskovli danielskovli changed the title Removes check on instantiate.error, resets isInstantiatingRef when error received Allow instantiation retry after failed attempt Feb 7, 2025
@danielskovli danielskovli marked this pull request as ready for review February 11, 2025 09:14
@danielskovli danielskovli merged commit 01a7376 into main Feb 11, 2025
22 of 24 checks passed
@danielskovli danielskovli deleted the fix/instantiation-not-triggering branch February 11, 2025 09:35
@olemartinorg
Copy link
Contributor

olemartinorg commented Feb 11, 2025

@danielskovli
Copy link
Contributor Author

Reported release information to servicedesk. Implementation tests ok on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants