-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New expression functions: compare
, string functions and more
#2961
Open
olemartinorg
wants to merge
23
commits into
main
Choose a base branch
from
feat/compare-and-more
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,295
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bjosttveit
reviewed
Feb 3, 2025
bjosttveit
reviewed
Feb 3, 2025
bjosttveit
reviewed
Feb 3, 2025
src/features/expressions/shared-tests/functions/stringSlice/together.json
Outdated
Show resolved
Hide resolved
…multiple folders there)
…ed regex for date parsing, making error messages look the same everywhere, adding support for multiple test-cases in one test (as was implemented on the backend).
…mplementing the same validations as on the backend
… was because a bug I introduced when parsing, not something wrong with formatting.
bjosttveit
approved these changes
Feb 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the following new expression functions:
countDataElements
- counts the number of data elements in the current instance, given a type. Can for example count attachments or subform elements.compare
equals
,greaterThan
,greaterThanEq
,lessThan
andlessThanEq
- all of which had dedicated functions alreadyisBefore
,isBeforeEq
,isAfter
,isAfterEq
andisSameDay
- these are all brand new, and relies on date parsingstringIndexOf
,stringReplace
,stringSlice
,lowerCaseFirst
andupperCaseFirst
Also, review comments from #2948 have also been solved here.
Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping