Add prometheus metrics for Hikari connection pool.

Altinity · Feb 5, 2025 · b435571 · b435571
1 parent 4b7eb6b
commit b435571
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/common/Metrics.java b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/common/Metrics.java
@@ -81,17 +81,6 @@ public static void initialize(String enableFlag, String metricsPort) {
 
         connectorStartTimeMs = System.currentTimeMillis();
 
-        // Register reporters here.
-//        reporter = ConsoleReporter.forRegistry(registry)
-//                .convertRatesTo(TimeUnit.SECONDS)
-//                .convertDurationsTo(TimeUnit.SECONDS)
-//                .build();
-//        reporter.start(1, TimeUnit.MINUTES);
-
-        //            registry = new MetricRegistry();
-//            registry.register("memory", new MemoryUsageGaugeSet());
-//            registry.register("jvm.thread-states",new ThreadStatesGaugeSet());
-//            registry.register("jvm.garbage-collector",new GarbageCollectorMetricSet());
         parseConfiguration(enableFlag, metricsPort);
 
         if(enableMetrics) {

diff --git a/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/db/HikariDbSource.java b/sink-connector/src/main/java/com/altinity/clickhouse/sink/connector/db/HikariDbSource.java
@@ -1,8 +1,10 @@
 package com.altinity.clickhouse.sink.connector.db;
 
+import com.altinity.clickhouse.sink.connector.common.Metrics;
 import com.clickhouse.jdbc.ClickHouseDataSource;
 import com.zaxxer.hikari.HikariConfig;
 import com.zaxxer.hikari.HikariDataSource;
+import io.micrometer.prometheus.PrometheusMeterRegistry;
 
 import java.sql.Connection;
 import java.sql.SQLException;
@@ -53,5 +55,11 @@ public void createConnectionPool(ClickHouseDataSource dataSource, String databas
         poolConfig.setDataSource(dataSource);
 
         this.dataSource = new HikariDataSource(poolConfig);
+
+        PrometheusMeterRegistry meterRegistry = Metrics.meterRegistry();
+
+        if(meterRegistry != null) {
+            this.dataSource.setMetricRegistry(meterRegistry);
+        }
     }   
 }