Skip to content

Commit

Permalink
Modified integration tests to close hikari connection pool.
Browse files Browse the repository at this point in the history
  • Loading branch information
subkanthi committed Feb 6, 2025
1 parent 79d666a commit 8d3a241
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ public void startContainers() throws InterruptedException {
.withExposedPorts(8123);
//.waitingFor(new HttpWaitStrategy().forPort(zookeeperContainer.getFirstMappedPort()));
clickHouseContainer.withNetwork(network).withNetworkAliases("clickhouse");
// clickHouseContainer.start();
//clickHouseContainer.start();

BasicConfigurator.configure();
mySqlContainer.start();
// clickHouseContainer.start();
clickHouseContainer.start();
Thread.sleep(35000);

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void testAutoCreateTable(String clickHouseServerVersion) throws Exception

BaseDbWriter writer = ITCommon.getDBWriter(clickHouseContainer);
Thread.sleep(10000);
ResultSet dateTimeResult = writer.executeQueryWithResultSet("select count(*) from `employees.new-table`");
ResultSet dateTimeResult = writer.executeQueryWithResultSet("select count(*) from employees.`new-table`");
boolean resultReceived = false;

while(dateTimeResult.next()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
import java.util.LinkedHashMap;
import java.util.Map;

import static io.debezium.storage.jdbc.JdbcCommonConfig.CONFIGURATION_FIELD_PREFIX_STRING;

/**
* Class that abstracts all functionality
* related to interacting with Clickhouse DB.
Expand Down Expand Up @@ -164,7 +166,7 @@ public String getOffsetStorageDatabaseName() {

String offsetSchemaHistoryTable = null;
try {
offsetSchemaHistoryTable = config.getString(JdbcOffsetBackingStoreConfig.PROP_TABLE_NAME.name());
offsetSchemaHistoryTable = config.getString(CONFIGURATION_FIELD_PREFIX_STRING + JdbcOffsetBackingStoreConfig.PROP_TABLE_NAME.name());
} catch(Exception e) {
log.error("***** Error retrieving offset store configuration ****", e);
}
Expand Down

0 comments on commit 8d3a241

Please sign in to comment.