Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sakari/enc/fix register page #98

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Sakari/enc/fix register page #98

merged 7 commits into from
Sep 21, 2024

Conversation

Skoivumaki
Copy link
Member

Requested changes done on issue #76

  • we should remove fields: name, backpack capacity and unique identifier
  • confirming text should be changed to -> "vakuutan että olen yli 13 vuotias tai minulla on vanhempieni lupa osallistua pelin sosiaaliseen toimintaan"'
  • confirming text should be translated

image

Stuff done:

  • Updated consent field text locales and fixed on submit error text
  • Removed fields from form: name, backpack capacity and unique identifier (API requires backpackCapacity, uniqueIdentifier and name fields to be filled. Used username as uniqueIdentifier and name to POST 201.)
  • Updated auth model/schema to include above13 boolean
  • Tested to be working
  • API requires backpackCapacity, uniqueIdentifier and name fields to be filled. Used username as uniqueIdentifier and name to post 201.

@Skoivumaki Skoivumaki added the enhancement For improvements to existing features label Sep 20, 2024
@leolabdev leolabdev merged commit 3c82ce8 into dev Sep 21, 2024
1 check passed
@leolabdev leolabdev deleted the sakari/enc/fix-register-page branch September 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants