Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samu/enhancement/304-redesign-feedback-button #390

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

SProkopios
Copy link
Contributor

closes #304

🔧 Changes Made

  • Added a megaphone icon to the feedback component
  • Updated colors and fonts
  • Implemented an active state for the feedback button
  • Added mouse event to close pop-up when clicking outside of it or the button
  • Enhanced the feedbackcard to match the figma desing
  • Improved title font implementation

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected. ✅
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.✅
  • Clean Code: Removed commented-out or unnecessary code.✅
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

Here is the screenshot of the button and pop-up:
Button

button(2)

Copy link
Collaborator

@Jonroi Jonroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You managed to clean up the code and add new fonts in a simple and effective way. Everything looks well-structured and easy to follow. Nice work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job of refining small styling details while also enhancing other aspects of the design.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good move towards simplifying the code

Copy link
Collaborator

@Jonroi Jonroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a conflict during the build process. Update the tests for this component so that everything works smoothly.
image

@SProkopios
Copy link
Contributor Author

Test are fixed, should run smoothly now!

@SProkopios SProkopios requested a review from Jonroi February 13, 2025 15:09
Copy link
Collaborator

@Jonroi Jonroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍🏻

@Jonroi Jonroi merged commit 5b3775b into dev Feb 14, 2025
1 check passed
@Jonroi Jonroi deleted the Samu/enhancement/304-redesign-feedback-button branch February 14, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants