Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete adding gameCoins on frontend #144

Open
leolabdev opened this issue Oct 7, 2024 · 5 comments
Open

delete adding gameCoins on frontend #144

leolabdev opened this issue Oct 7, 2024 · 5 comments
Assignees
@Skoivumaki
Labels
easy level_easy refactor For code refactoring

Comments

@leolabdev
Copy link
Member

check Alt-Org/Altzone-Server#238

as I remeber we had to hardcode it ?
@leolabdev leolabdev added refactor For code refactoring easy level_easy labels Oct 7, 2024
@Jonroi Jonroi moved this to Backlog in altzone-webpages Oct 9, 2024
@Skoivumaki
Copy link
Member

Yes hardcoded kindof: On clan creation frontend gave API gameCoin value of 1 (was default).

gameCoins: yup
.number()
.default(1)
.min(1, "Pelikolikoiden on oltava vähintään 1")
.max(5000, "Pelikolikoiden on oltava enintään 1500"),

@Skoivumaki Skoivumaki mentioned this issue Oct 10, 2024
Closed
@leolabdev
Copy link
Member Author

@MikhailDeriabin Will this update be deployed soon?

@leolabdev
Copy link
Member Author

@Skoivumaki Mikhail announced an API update today, I think it can be removed now?

@Skoivumaki Skoivumaki moved this to On Hold in altzone-webpages Nov 18, 2024
@Skoivumaki
Copy link
Member

issue put on hold until #256 is complete.

@Skoivumaki
Copy link
Member

Skoivumaki commented Jan 9, 2025 •
edited
Loading

image
Clan creation no longer needs gameCoins to be declared, however request still succeeds even if they are declared. (wont cause issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skoivumaki Skoivumaki

Labels
easy level_easy refactor For code refactoring
Projects
altzone-webpages
Status: On Hold
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

sakari/refactor/144-delete-adding-gamecoins-on-frontend Alt-Org/Altzone-WebPages
2 participants
@leolabdev @Skoivumaki