Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 588 daq validator #607

Merged
merged 18 commits into from
Nov 27, 2023
Merged

Feat 588 daq validator #607

merged 18 commits into from
Nov 27, 2023

Conversation

Sun-flow
Copy link
Contributor

closes #588

Adds validators to rig and session schema for DAQ channels to ensure that if a DAQ is connected, the port it is connected to is a named and existing device in the schema.

Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks close - a few questions

@Sun-flow Sun-flow requested a review from saskiad November 21, 2023 22:24
tests/test_imaging.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small things - lmk if you need more information

@Sun-flow Sun-flow requested a review from saskiad November 22, 2023 18:38
@saskiad saskiad merged commit fe9ee8a into main Nov 27, 2023
@saskiad saskiad deleted the feat-588-DAQ-validator branch November 27, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator for device_name of DAQDevices in rig and instrument schema
3 participants