feat: replace experimenter_full_name with Investigator class #1223
Conversation
Oh I missed investigators, but also didn't we agree months ago to deprecate PIDName in favor of this exact kind of change where the registry is pre-populated for users? |
|
Few more places where *_full_name pattern needs to be replaced |
…age-with-a-class-researchername
dbirman
changed the title
| @@ -41,7 +41,7 @@ class DataDescription(DataCoreModel): | |||
| _DESCRIBED_BY_URL = DataCoreModel._DESCRIBED_BY_BASE_URL.default + "aind_data_schema/core/data_description.py" | |||
| describedBy: str = Field(default=_DESCRIBED_BY_URL, json_schema_extra={"const": _DESCRIBED_BY_URL}) | |||
| schema_version: SkipValidation[Literal["1.0.4"]] = Field(default="1.0.4") | |||
| license: Literal["CC-BY-4.0"] = Field("CC-BY-4.0", title="License") | |||
| license: Literal["CC-BY-4.0"] = Field(default="CC-BY-4.0", title="License") | |||
There was a problem hiding this comment.
Does it make sense to have a default for a literal? I thought the point of a literal is to have a fixed value. (This is a question, not a review ... )
There was a problem hiding this comment.
Not related to the literal (and this probably shouldn't be in this PR, I'll remove it). Some linters seem to struggle with interpreting the default value as the default unless you set it explicitly, so when you try to instantiate a DataDescription object the linter complains that the license field is required
There was a problem hiding this comment.
that's odd. we should see if Jon has thoughts on this. I'm not opposed to having the default, I just was surprised by it.
saskiad
deleted the
1175-20-replace-field_full_name-usage-with-a-class-researchername
branch
This PR replaces all usage of
*_full_name: strwithinvestigator: List[Investigator]and introduces a new classInvestigator. AnInvestigatorcan be defined either with a first and last name (and optional orcid id) or with an anonymous ID string.