fix: pull datetime at runtime instead of at package import time #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbirman
requested review from
saskiad and
helen-m-lin
and removed request for
saskiad
|
Closes #1204 |
helen-m-lin
approved these changes
Jan 2, 2025
dbirman
deleted the
1169-datetime-value-evaluated-at-package-import-for-qc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
QualityControl.status()function where the defaultdateparameter was being set at package import time instead of at runtime. This causes an issue in downstream code where if a server doesn't get restarted fairly often then it flags QC data with dates in the future (from it's perspective) as being invalid.