Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backward compatible refactor "sitmulus_name" in AuditoryStimulation #1144

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Nov 7, 2024

PR refactors a typo "sitmulus_name" -> "stimulus_name" in the AuditoryStimulation class and ensures backward compatibility by adding a model_validator that runs in mode before.

@dbirman dbirman linked an issue Nov 7, 2024 that may be closed by this pull request
@dbirman
Copy link
Member Author

dbirman commented Nov 7, 2024

Tests are failing due to #1143

@dbirman dbirman requested a review from dyf November 8, 2024 06:25
@dbirman dbirman added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dev with commit 601a974 Nov 8, 2024
5 checks passed
@dbirman dbirman deleted the 1137-typo-in-auditorystimulation-class-property branch November 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in AuditoryStimulation class property
2 participants