Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create metadata json from core fields #1136

Merged
merged 5 commits into from
Nov 4, 2024
Merged

feat: create metadata json from core fields #1136

merged 5 commits into from
Nov 4, 2024

Conversation

helen-m-lin
Copy link
Contributor

@helen-m-lin helen-m-lin commented Oct 31, 2024 •
edited
Loading

closes #1066

  • Consolidates metadata.nd.json creation logic from aind-metadata-mapper and aind-data-asset-indexer
  • Add unit tests for new class method

I tested use cases from aind-metadata-mapper and aind-data-asset-indexer to ensure compatibility.

@helen-m-lin helen-m-lin marked this pull request as ready for review November 1, 2024 18:11
@saskiad saskiad added this pull request to the merge queue Nov 4, 2024
Merged via the queue into dev with commit 3c2c99d Nov 4, 2024
5 checks passed
@saskiad saskiad deleted the feat-1066-metadata-json-creation branch November 4, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saskiad saskiad saskiad approved these changes

@jtyoung84 jtyoung84 jtyoung84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move metadata.nd.json logic to aind-data-schema
3 participants
@helen-m-lin @saskiad @jtyoung84