Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to add QCMetric class and list of URLs for reference images/figures #1037

Merged
merged 11 commits into from
Aug 30, 2024

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Aug 26, 2024

No description provided.

@dbirman dbirman linked an issue Aug 26, 2024 that may be closed by this pull request
@dbirman dbirman requested a review from saskiad August 27, 2024 16:37
Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the defaults. Also a quick question on how you envision using it

@dbirman
Copy link
Member Author

dbirman commented Aug 29, 2024

Added quality_control.Stage per discussion, and modified examples to better reflect our concept. Also added name to QCEvaluation and made descriptions optional, to separate stage/name/desc from each other.

@dbirman dbirman requested a review from saskiad August 29, 2024 18:45
Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor things, but otherwise I think it's good.

@dbirman dbirman requested a review from saskiad August 30, 2024 17:33
@saskiad saskiad added this pull request to the merge queue Aug 30, 2024
Merged via the queue into dev with commit 8246813 Aug 30, 2024
5 checks passed
@saskiad saskiad deleted the 1021-enable-qcevaluation-to-include-path-to-images branch August 30, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable QCEvaluation to include path to images
2 participants