Skip to content

Commit

Permalink
linting
Browse files Browse the repository at this point in the history
  • Loading branch information
saskiad committed Nov 17, 2024
1 parent 55651ee commit b6d07b2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/aind_data_schema/core/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ModelEvaluation(AindModel):
"""Description of model evaluation"""

data: Optional[str] = Field(default=None, title="Path to evaluation data")
data_description: Optional[str] = Field(default=None, title="Description of evaluation data")
data_description: Optional[str] = Field(default=None, title="Description of evaluation data")
date: AwareDatetimeWithDefault = Field(..., title="Date")
performance: List[PerformanceMetric] = Field(..., title="Evaluation performance")
notes: Optional[str] = Field(default=None, title="Notes")
Expand Down
13 changes: 7 additions & 6 deletions tests/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

from aind_data_schema_models.modalities import Modality
from aind_data_schema_models.organizations import Organization
from aind_data_schema_models.process_names import ProcessName
from aind_data_schema_models.system_architecture import ModelBackbone

from aind_data_schema.core.model import Model, ModelArchitecture, ModelEvaluation, ModelTraining, PerformanceMetric
from aind_data_schema.components.devices import Software


class ModelTests(unittest.TestCase):
"""tests for model"""

Expand All @@ -36,9 +36,9 @@ def test_constructors(self):
parameters={
"downsample": 1,
"input_shape": [
14,
14,
26
14,
14,
26
],
"learning_rate": 0.0001,
"train_test_split": 0.8,
Expand Down Expand Up @@ -86,11 +86,12 @@ def test_constructors(self):
)
]
)

Model.model_validate_json(m.model_dump_json())

self.assertIsNotNone(m)


if __name__ == "__main__":
unittest.main()
unittest.main()

0 comments on commit b6d07b2

Please sign in to comment.