Skip to content

Commit

Permalink
Correct setter anti-pattern where setter has a different type than ge…
Browse files Browse the repository at this point in the history
…tter
  • Loading branch information
bruno-f-cruz committed Oct 28, 2024
1 parent 758d1f1 commit 259f844
Showing 1 changed file with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -284,35 +284,31 @@ def bonsai_app(self) -> BonsaiApp:
raise ValueError("BonsaiApp is not set.")
return srv

@bonsai_app.setter
def bonsai_app(self, value: _TServiceFactory[BonsaiApp] | BonsaiApp) -> None:
def attach_bonsai_app(self, value: _TServiceFactory[BonsaiApp] | BonsaiApp) -> None:
self.attach_service_factory("bonsai_app", value)

@property
def data_mapper(self) -> Optional[DataMapperService]:
srv = self.try_get_service("data_mapper")
return self._validate_service_type(srv, DataMapperService)

@data_mapper.setter
def data_mapper(self, value: _TServiceFactory[DataMapperService]) -> None:
def attach_data_mapper(self, value: _TServiceFactory[DataMapperService]) -> None:
self.attach_service_factory("data_mapper", value)

@property
def resource_monitor(self) -> Optional[ResourceMonitor]:
srv = self.try_get_service("resource_monitor")
return self._validate_service_type(srv, ResourceMonitor)

@resource_monitor.setter
def resource_monitor(self, value: _TServiceFactory[ResourceMonitor]) -> None:
def attach_resource_monitor(self, value: _TServiceFactory[ResourceMonitor]) -> None:
self.attach_service_factory("resource_monitor", value)

@property
def data_transfer(self) -> Optional[DataTransferService]:
srv = self.try_get_service("data_transfer")
return self._validate_service_type(srv, DataTransferService)

@data_transfer.setter
def data_transfer(self, value: _TServiceFactory[DataTransferService]) -> None:
def attach_data_transfer(self, value: _TServiceFactory[DataTransferService]) -> None:
self.attach_service_factory("data_transfer", value)

@staticmethod
Expand Down

0 comments on commit 259f844

Please sign in to comment.