Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGLF] MC process functions + dcaXY selection #9896

Merged
merged 17 commits into from
Feb 16, 2025

Conversation

nepeivodaRS
Copy link
Contributor

@nepeivodaRS nepeivodaRS commented Feb 11, 2025

  1. Added processV0sMC and processGenerated functions to compute efficiency corrections
  2. Added selDauDCA selection bit to eliminate auto-correlations with global tracks

@github-actions github-actions bot added the pwglf label Feb 11, 2025
@github-actions github-actions bot changed the title PWG-LF: MC process functions + dcaXY selection [PWGLF] PWG-LF: MC process functions + dcaXY selection Feb 11, 2025
nepeivodaRS and others added 2 commits February 11, 2025 20:44
@nepeivodaRS nepeivodaRS changed the title [PWGLF] PWG-LF: MC process functions + dcaXY selection [PWGLF] MC process functions + dcaXY selection Feb 11, 2025
@nepeivodaRS nepeivodaRS marked this pull request as ready for review February 11, 2025 21:27
@nepeivodaRS
Copy link
Contributor Author

Hi, I’m getting O2 linter warnings asking me to change the names of the workflows in CMakeLists.txt. If I make those changes, I’ll also need to rename the corresponding files and update the file descriptions. This would trigger all the related warnings for each file. Addressing all the tasks in the strangeness folder would require a significant amount of work. Can this be merged without those changes?

njacazio
njacazio previously approved these changes Feb 11, 2025
@njacazio
Copy link
Collaborator

Yes but the compilation ci must pass

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for e840743 at 2025-02-12 12:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9896-slc9_x86-64/0/PWGLF/Tasks/Strangeness/derivedupcanalysis.cxx:1770:48: error: unused parameter 'CascMCCores' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@nepeivodaRS
Copy link
Contributor Author

@njacazio, could you please re-approve the PR and enable auto-merging? I had to fix a compilation warning, which dismissed your approval.

@njacazio njacazio merged commit 5523fa6 into AliceO2Group:master Feb 16, 2025
11 of 13 checks passed
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants