Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-536] Improve runs overview detectors filter #1840

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Refactored runs overveiw detectors filter

Changes made to the database:

  • N/A

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (e539a88) to head (33d44c4).

Files with missing lines Patch % Lines
lib/public/services/RemoteDataProvider.js 0.00% 25 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 17 Missing ⚠️
lib/public/services/detectors/detectorsProvider.js 0.00% 6 Missing ⚠️
.../detector/ObservableBasedSelectionDropdownModel.js 0.00% 4 Missing ⚠️
lib/public/services/tag/tagsProvider.js 0.00% 4 Missing ⚠️
...public/components/Filters/common/TagFilterModel.js 0.00% 2 Missing ⚠️
...nts/Filters/RunsFilter/detectorsFilterComponent.js 0.00% 1 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 1 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 1 Missing ⚠️
lib/public/views/Tags/Details/TagDetailsModel.js 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   43.86%   44.06%   +0.19%     
==========================================
  Files         891      892       +1     
  Lines       15971    15969       -2     
  Branches     3020     3017       -3     
==========================================
+ Hits         7006     7036      +30     
+ Misses       8965     8933      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais changed the title [O2B-532] Improve runs overview detectors filter [O2B-536] Improve runs overview detectors filter Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant