Fix QC flag types randomly failing (#1842)

AliceO2Group · Jan 30, 2025 · f3937b5 · f3937b5
1 parent e539a88
commit f3937b5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/test/public/defaults.js b/test/public/defaults.js
@@ -407,6 +407,10 @@ module.exports.expectInnerText = async (page, selector, innerText) => {
     } catch (_) {
         const actualInnerText = await getInnerText(elementHandle);
         await elementHandle.dispose();
+        if (actualInnerText === innerText) {
+            // Timeout issue resolved by itself, simply return (kind of retry for free)
+            return;
+        }
         throw new Error(`Expected innerText for ${selector} to be "${innerText}", got "${actualInnerText}"`);
     }
     await elementHandle.dispose();

diff --git a/test/public/qcFlagTypes/creation.test.js b/test/public/qcFlagTypes/creation.test.js
@@ -21,6 +21,8 @@ const {
     expectInnerText,
     waitForNavigation,
     expectUrlParams,
+    waitForTableLength,
+    expectAttributeValue,
 } = require('../defaults.js');
 const { resetDatabaseContent } = require('../../utilities/resetDatabaseContent.js');
 
@@ -75,8 +77,15 @@ module.exports = () => {
 
         await waitForNavigation(page, () => pressElement(page, 'button#submit', true));
         expectUrlParams(page, { page: 'qc-flag-types-overview' });
+        await waitForTableLength(page, 8);
 
         // Expect newly created flag to appear and have correct color
-        await expectInnerText(page, '[style*="rgb(240, 0, 240)"]', 'AAA+');
+        await expectAttributeValue(
+            page,
+            '#row21-name-text .badge',
+            'style',
+            'border-color: rgb(240, 0, 240); background-color: rgb(240, 0, 240); color: white;',
+        );
+        await expectInnerText(page, '#row21-name-text', 'AAA+');
     });
 };