Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aod-merger treats Zombie files like missing ones #13942

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Feb 5, 2025

Zombie (corrupted) files will be skipped instead of crashing the job if the option
--skip-non-existing-files is requested.

@shahor02 shahor02 requested a review from a team as a code owner February 5, 2025 15:16
Copy link
Contributor

github-actions bot commented Feb 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alcaliva alcaliva enabled auto-merge (squash) February 5, 2025 15:20
@shahor02 shahor02 disabled auto-merge February 5, 2025 16:50
@shahor02 shahor02 merged commit de69487 into AliceO2Group:dev Feb 5, 2025
9 of 12 checks passed
@jgrosseo
Copy link
Collaborator

jgrosseo commented Feb 6, 2025

@shahor02 According to the docs, the situation should never occur...

image

@shahor02
Copy link
Collaborator Author

shahor02 commented Feb 6, 2025

@jgrosseo did not know about that, thanks! But the log before the crash was clearly showing "zombie" state. Is merging run with --skip-non-existing-files ?

@jgrosseo
Copy link
Collaborator

jgrosseo commented Feb 6, 2025

I guess depends which merging you are talking about. Usually we don't skip files in analysis for example. What job was this?

@shahor02
Copy link
Collaborator Author

shahor02 commented Feb 6, 2025

Merging of MC AOD's, should ask Mesut which one.

@chiarazampolli
Copy link
Collaborator

Taking a random MC merging, I see it is not used:

https://alimonitor.cern.ch/users/download.jsp?view=true&path=/alice/cern.ch/user/a/aliprod/LHC23k6/AOD_merge.sh

what is called is only

o2-aod-merger --input list.list

@catalinristea and Michal Broz should confirm if it is always like this.

Chiara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants