-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCH: fixes to the ST2 pads mapping #13938
base: dev
Are you sure you want to change the base?
Conversation
The relation between pad positions and electronics channels was wrong for five consecutive motif types on the bending side of ST2 quadrants (types "2Bv1" to "2Bv5"). The code is generated from the changes applied in mrrtf/alo#74 For more details see https://its.cern.ch/jira/browse/MCH-5
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Error while checking build/O2/fullCI for d18b383 at 2025-02-05 13:03:
Full log here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aferrero2707, it looks good to me. I ran the 2 tests checking the pad indices in the mapping (ctest -R o2-test-mchmapping-pad-indices-impl4
from the build directory) and they both passed.
For the record, one can also run the stress tests of the mapping with the command |
The relation between pad positions and electronics channels was wrong for five consecutive motif types on the bending side of ST2 quadrants (types "2Bv1" to "2Bv5").
The code is generated from the changes applied in mrrtf/alo#74
For already existing CTFs, the mapping can be "patched" with the code in #13924.
For more details see https://its.cern.ch/jira/browse/MCH-5