Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCH: fixes to the ST2 pads mapping #13938

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

aferrero2707
Copy link
Collaborator

@aferrero2707 aferrero2707 commented Feb 5, 2025

The relation between pad positions and electronics channels was wrong for five consecutive motif types on the bending side of ST2 quadrants (types "2Bv1" to "2Bv5").

The code is generated from the changes applied in mrrtf/alo#74

For already existing CTFs, the mapping can be "patched" with the code in #13924.

For more details see https://its.cern.ch/jira/browse/MCH-5

The relation between pad positions and electronics channels
was wrong for five consecutive motif types on the bending
side of ST2 quadrants (types "2Bv1" to "2Bv5").

The code is generated from the changes applied in
mrrtf/alo#74

For more details see https://its.cern.ch/jira/browse/MCH-5
@aferrero2707 aferrero2707 requested review from shahor02 and a team as code owners February 5, 2025 10:00
Copy link
Contributor

github-actions bot commented Feb 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aferrero2707
Copy link
Collaborator Author

@pillot @lmassacr here is the corrected mapping for ST2.

I have checked that this updated mapping and the "patching" from #13924 produce the same list of preclusters, using some raw TFs of run 544490.

@alibuild
Copy link
Collaborator

alibuild commented Feb 5, 2025

Error while checking build/O2/fullCI for d18b383 at 2025-02-05 13:03:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[28770:internal-dpl-ccdb-backend]: [12:03:35][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[28770:internal-dpl-ccdb-backend]: [12:03:35][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[28770:internal-dpl-ccdb-backend]: [12:03:34][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
[28770:internal-dpl-ccdb-backend]: [12:03:34][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1550600800000 (agent_id: alimetal09.cern.ch-1738757011-MgpmO8) with http code: 0
[28770:internal-dpl-ccdb-backend]: [12:03:34][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[28770:internal-dpl-ccdb-backend]: [12:03:35][ERROR] Exception while running: Fatal error. Rethrowing.
[28770:internal-dpl-ccdb-backend]: [12:03:35][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 28770 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 28770 (exit 128)
[INFO]    - First error: [12:03:34][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (28770) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/45d7adfcd1f7a8b279c39a16e00507d62c5d773e/slc8_x86-64/o2checkcode/1.0-local70/etc/modulefiles
++ cat
--

Full log here.

Copy link
Collaborator

@pillot pillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aferrero2707, it looks good to me. I ran the 2 tests checking the pad indices in the mapping (ctest -R o2-test-mchmapping-pad-indices-impl4 from the build directory) and they both passed.

@pillot
Copy link
Collaborator

pillot commented Feb 5, 2025

For the record, one can also run the stress tests of the mapping with the command ctest -C Release -R o2-test-mchmapping. 6 tests are running in total, and they all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants