Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL Analysis: reduce amount of base types for columns #13933

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

aalkin
Copy link
Member

@aalkin aalkin commented Feb 4, 2025

No description provided.

@aalkin aalkin requested a review from a team as a code owner February 4, 2025 11:29
Copy link
Contributor

github-actions bot commented Feb 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aalkin aalkin force-pushed the refactor-column-types branch from d058635 to ccef8a1 Compare February 4, 2025 11:32
@alibuild
Copy link
Collaborator

alibuild commented Feb 4, 2025

Error while checking build/O2/fullCI_slc9 for 82f125b at 2025-02-04 13:18:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2499:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2798:1: error: expected declaration before '}' token
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2499:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2798:1: error: expected declaration before '}' token
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2499:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2798:1: error: expected declaration before '}' token
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2499:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2798:1: error: expected declaration before '}' token
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2499:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2798:1: error: expected declaration before '}' token
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2797:1: error: version control conflict marker in file
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2014:20: error: 'McMask' was not declared in this scope
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2306:143: error: no matching function for call to 'o2::framework::TypeIdHelpers::uniqueId<<expression error> >()'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2306:143: error: template argument 1 is invalid
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2307:142: error: no matching function for call to 'o2::framework::expressions::BindingNode::BindingNode(<brace-enclosed initializer list>)'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2307:142: error: could not convert '{"fMcMask", <expression error>, o2::framework::expressions::selectArrowType<short unsigned int>()}' from '<brace-enclosed initializer list>' to 'const o2::framework::expressions::BindingNode'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2016:2: error: expected ';' after struct definition
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2691:42: error: too few arguments to function 'void o2::soa::dereferenceWithWrongType(const char*, const char*)'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2704:42: error: too few arguments to function 'void o2::soa::dereferenceWithWrongType(const char*, const char*)'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2750:42: error: too few arguments to function 'void o2::soa::dereferenceWithWrongType(const char*, const char*)'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:2763:42: error: too few arguments to function 'void o2::soa::dereferenceWithWrongType(const char*, const char*)'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2019:59: error: 'McMask' is not a member of 'o2::aod::mccalolabel'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3167:87: error: template argument 3 is invalid
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3181:10: error: specialization of 'template<class D> struct o2::aod::MetadataTrait' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3181:10: error: explicit specialization of 'template<class D> struct o2::aod::MetadataTrait' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2018:19: error: 'McCaloLabels_000Metadata' does not name a type; did you mean 'McCollisions_000Metadata'?
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2021:70: error: 'AmplitudeA' is not a member of 'o2::aod::mccalolabel'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3167:87: error: template argument 3 is invalid
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3181:10: error: specialization of 'template<class D> struct o2::aod::MetadataTrait' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3181:10: error: explicit specialization of 'template<class D> struct o2::aod::MetadataTrait' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/AnalysisDataModel.h:2020:29: error: 'McCaloLabels_001Metadata' does not name a type; did you mean 'McCollisions_001Metadata'?
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1704:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<2466602402>, o2::aod::Hash<3237148914>, o2::aod::Hash<2286545062> >::ref>()'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1704:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<3237148914> >'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1844:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<2466602402>, o2::aod::Hash<3237148914>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<2466602402>, o2::aod::Hash<3237148914>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1844:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<2466602402>, o2::aod::Hash<3237148914>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<2466602402>, o2::aod::Hash<3237148914>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: specialization of 'template<unsigned int H> struct o2::aod::Hash' in different namespace [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:273:10: error: explicit specialization of 'template<unsigned int H> struct o2::aod::Hash' outside its namespace must use a nested-name-specifier [-fpermissive]
/sw/SOURCES/O2/13933-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:3181:10: error: specialization of 'template<class D> struct o2::aod::MetadataTrait' in different namespace [-fpermissive]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants