Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCH: cosmetic changes to detector mapping #13927

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

aferrero2707
Copy link
Collaborator

@aferrero2707 aferrero2707 commented Feb 3, 2025

This are cosmetic changes to the cathode segmentations that do not change the actual mapping, they simply make the formatting homogeneous and will improve the readability of future commits.

The code formatting is uniformized among the different source files.
This will also make future commits to the mapping code more readable.
@aferrero2707 aferrero2707 requested review from shahor02 and a team as code owners February 3, 2025 07:33
Copy link
Contributor

github-actions bot commented Feb 3, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@aferrero2707 aferrero2707 changed the title [WIP] MCH: fixes for the ST2 detector mapping MCH: cosmetic changes to detector mapping Feb 3, 2025
@aferrero2707
Copy link
Collaborator Author

aferrero2707 commented Feb 3, 2025

@pillot @shahor02 one CI job failed for unrelated reasons, seems to be a problem with the current daily builds. I got the same failure also in #13924.

@shahor02
Copy link
Collaborator

shahor02 commented Feb 3, 2025

@aferrero2707 the failure is unrelated, shall I merge it?

Copy link
Collaborator

@pillot pillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge on my side.

@shahor02 shahor02 merged commit 2b593a2 into AliceO2Group:dev Feb 4, 2025
14 of 15 checks passed
@aferrero2707
Copy link
Collaborator Author

@aferrero2707 the failure is unrelated, shall I merge it?

@shahor02 yes, please... thanks!

@aferrero2707 aferrero2707 deleted the mch-st2-mapping-update branch February 4, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants