-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL Analysis: remove selected_pack (fixed) #13915
base: dev
Are you sure you want to change the base?
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
|
||
template <typename G, typename A> | ||
expressions::BindingNode getMatchingIndexNode() | ||
{ | ||
using external_index_columns_pack = typename A::external_index_columns_t; | ||
using selected_indices_t = selected_pack_multicondition<is_index_to_g_t, pack<G>, external_index_columns_pack>; | ||
using selected_indices_t = selected_pack_multicondition<is_index_to_g_t, pack<G>, typename A::columns_t>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, selected_indices_t is only used with pack_head_t<selected_indices_t>. Why do you need to calculate the selection? Can't you simply find the first occurrence, if any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I avoided affecting the combinations for now, I intend to look more closely in the next pass. But you are right, here the logic relies on finding the first compatible index.
@sy-c apparently kafka is now a requirement on cc8 for Readout. Can that be made optional and only enabled if Kafka itself is found (e.g. via |
Hello @ktf, the kafka dependency is inherited from the monitoring library. Is there a problem with that ? |
Error while checking build/O2/fullCI_slc9 for 859ec3d at 2025-02-03 14:36:
Full log here. |
overloaded{}
in templatesis_self_index_column
used in place ifis_index_column
)