Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: avoid asserting the workflow is empty #13904

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 28, 2025

This is a property that depends on user input, so an empty workflow is actually
possible and should be handled. This currently breaks if the empty workflow is
provided in debug mode.

@ktf ktf requested a review from a team as a code owner January 28, 2025 08:40
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

This is a property that depends on user input, so an empty workflow is actually
possible and should be handled. This currently breaks if the empty workflow is
provided in debug mode.
@ktf ktf merged commit f946c53 into AliceO2Group:dev Jan 28, 2025
12 of 13 checks passed
@ktf
Copy link
Member Author

ktf commented Jan 28, 2025

Tested locally, currently broken. Empty workflows need to be handled just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant