Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add termination for record writer to save record file correctly #13903

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Elros60
Copy link
Contributor

@Elros60 Elros60 commented Jan 27, 2025

Calling terminate function for RecordWriter when terminating aligner instance, making sure the millerecord file will be written to disk correctly.

@Elros60 Elros60 requested review from shahor02 and a team as code owners January 27, 2025 22:38
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@Elros60
Copy link
Contributor Author

Elros60 commented Jan 28, 2025

Building test failed for build/O2/o2/aarch64 and build/O2/o2_slc9, error msg pointed to:
Screenshot 2025-01-28 at 09 53 35
This should not relate to my current PR right?

@shahor02
Copy link
Collaborator

failures unrelated, merging.

@shahor02 shahor02 merged commit f2e7956 into AliceO2Group:dev Jan 28, 2025
13 of 15 checks passed
@Elros60 Elros60 deleted the dev_mchAlign branch January 28, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants