Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITS3: add metal layer + fix macros #13894

Draft
wants to merge 27 commits into
base: dev
Choose a base branch
from
Draft

ITS3: add metal layer + fix macros #13894

wants to merge 27 commits into from
+645 −375

Conversation

f3sch
Copy link
Collaborator

@f3sch f3sch commented Jan 23, 2025 •
edited
Loading

Needs #13895 and #13929.

@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch f3sch mentioned this pull request Jan 23, 2025
Draft
@alibuild alibuild mentioned this pull request Jan 31, 2025
Closed
@ChunzhengLab ChunzhengLab mentioned this pull request Feb 3, 2025
Open
f3sch added 25 commits February 3, 2025 13:30
@f3sch
ITS3: Add metalstack to geometry
222fb1a 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: correction to epitaxial layer
9fbc19a 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: small readme changes
56f2d9d 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Fix metal stack geo
0c241a7 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: change severity to debug
969d893 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: modify layer geo
3544675 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: make segmentation class header only
066e7b8 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: move pixelarray to start at zero phi
579d907 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: macro fixes
a68d51e 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: double precision for geometry + z-shift
2bc92af 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Digitizer constness
f8e49ae 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: macro include cluster eta, row, col
8bfe479 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: extend wrapvolZ to include outer edges
d9e52b2 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: remove unused var
e15faee 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: cluster macro
b7fbdba 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Add DigiParams
4429ad5 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: DigiParams amendment
a0e7de3 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Digitizer option to pick response function
8df63c9 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: build APTS response function
a4dd45f 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: renamed SuperAlpide to Mosaix
203de13 
This is essentially a rebase on the changes by @ChunzhengLab.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: digitizer pre-set response names
c35b5ca 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: remove unneeded variables + make segmentation fully float
1009ee7 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: scale pixel-resp + fix OB resp func
a320720 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: digitizer offset for Alpide resp.
db1210f 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: Segmenatation remove member prefix from vars
32669d7 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch force-pushed the its3/metal_stack_macros branch from 09f35ec to 32669d7 Compare February 3, 2025 12:31
f3sch added 2 commits February 3, 2025 13:35
@f3sch
ITS3: formatting params
577100e 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch
ITS3: shift back to nominal pos + proper metal stack position
9d22fb7 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa will be requested when the pull request is marked ready for review fgrosa is a code owner

@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 will be requested when the pull request is marked ready for review arossi81 is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas will be requested when the pull request is marked ready for review mconcas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f3sch