Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard afterburner tracks #12792

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Mar 1, 2024

Copy link
Contributor

github-actions bot commented Mar 1, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@f3sch
Copy link
Collaborator

f3sch commented Mar 1, 2024

Hi @shahor02, intuitively I would have thought this should be added here

 for (int itrk = 0; itrk < static_cast<int>(mITSTPCTracks.size()); ++itrk) {       // line 461
      auto const& trk = mITSTPCTracks[itrk];
      auto idxTrkTpc = trk.getRefTPC().getIndex();
      if (trk.getRefITS().getSource() != GID::ITS) {
             continue;
        }
      if (isTPCTrackSelectedEntry[idxTrkTpc] == true) {
        auto lbl = mRecoCont.getTrackMCLabel({(unsigned int)(itrk), GID::Source::ITSTPC});
        if (!lbl.isValid()) {
          continue;
        }

so before we build this mMapLabels, because otherwise I could imagine that this would somewhat mess with the normalisation. In this case we would exclude AB tracks entirely from the efficiency (might also not be ideal). I tested that they stop the crash.

@shahor02
Copy link
Collaborator Author

shahor02 commented Mar 1, 2024

@f3sch Makes sense, thanks!

@chiarazampolli
Copy link
Collaborator

I added the labels for pp 2023 apass3/PbPb apass3 only.

@chiarazampolli
Copy link
Collaborator

Tested by @f3sch .

@chiarazampolli chiarazampolli merged commit c435d77 into AliceO2Group:dev Mar 1, 2024
13 checks passed
@shahor02 shahor02 deleted the pr_itstpcqa branch March 4, 2024 09:37
chiarazampolli pushed a commit that referenced this pull request Mar 11, 2024
* Discard afterburner tracks

* Move ITSAB check before mMapLabels validation

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* Discard afterburner tracks

* Move ITSAB check before mMapLabels validation

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
* Discard afterburner tracks

* Move ITSAB check before mMapLabels validation

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
* Discard afterburner tracks

* Move ITSAB check before mMapLabels validation

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
noferini pushed a commit that referenced this pull request Apr 26, 2024
* Discard afterburner tracks

* Move ITSAB check before mMapLabels validation

---------

Co-authored-by: shahoian <ruben.shahoyan@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants