Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracks filtering on dedx to TPC tracking output #12640

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Feb 1, 2024

@wiechula @miranov25

Effect of default cut settings on 38kHz LHC23zzh_544116

tglnclcut

@shahor02 shahor02 requested a review from davidrohr as a code owner February 1, 2024 13:51
@miranov25
Copy link
Contributor

Reference presentation slide:

image

@miranov25
Copy link
Contributor

Hello @shahor02

Thank you for submitting the pull request.
I have looked at your implementation, and it matches what I described in my slides. From that perspective, I agree with you. However, I foresee a possible "side effect" in the future if the change remains unchanged. We would have to make sure that TPC dEdx is always set (dEdx!=0). Currently, we rarely encounter tracks with dEdx=0, but to be on the safe side, I suggest a slight code adjustment for additional protection:

  • If dEdx==0 and |eta| > is 0.03, we should not apply cuts (tiny part)

With this change, tracks with unsigned - dEdx=0 will also be considered.
Although this is currently not a problem, we have observed tracks with dEdx=0 in Run1 and Run2, especially near the sector edges where the last pad was not used for the dEdx calculation.

I am not sure what @wiechula is planning in this area, but I believe that the change I suggested would be an appropriate safety measure.

Marian

@miranov25
Copy link
Contributor

If the suggestion mentioned above is implemented, or if Jens confirms that tracks at the edges with undefined dEdx should not occur, I believe we are ready to proceed with the merge.

@miranov25
Copy link
Contributor

After thoroughly reviewing the code modification, I believe the implemented protection aligns with our agreement. Given this, I propose proceeding with the merge.

@shahor02 shahor02 merged commit a6618d5 into AliceO2Group:dev Feb 2, 2024
12 checks passed
@shahor02 shahor02 deleted the pr_tpcdedxcut branch February 2, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants