Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to tidyverse and scIntro notebooks #760

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

sjspielman
Copy link
Member

Part of #743

Here, I've made two changes to scIntro notebooks as noted in #743:

Let me know what you think of the plot addition for the second fix!

@sjspielman sjspielman requested a review from allyhawkins April 18, 2024 14:14
@allyhawkins
Copy link
Member

Did you look at the total UMI counts plots when making this change? Can you post what they look like?

@sjspielman
Copy link
Member Author

Yup!

Screenshot 2024-04-18 at 12 17 49 PM
Screenshot 2024-04-18 at 12 17 42 PM

Co-authored-by: Ally Hawkins <54039191+allyhawkins@users.noreply.github.com>
@sjspielman
Copy link
Member Author

With viridis. I think it looks reasonable for the point we want to make, what do you think?

Screenshot 2024-04-18 at 1 04 22 PM
Screenshot 2024-04-18 at 1 04 08 PM

@sjspielman sjspielman requested a review from allyhawkins April 18, 2024 17:05
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viridis definitely helps. I'm curious if people will find this helpful, so let's try it! We can always take it out if we get too many questions.

@sjspielman sjspielman merged commit b8f66b0 into master Apr 18, 2024
2 checks passed
@sjspielman sjspielman deleted the sjspielman/743-scintro-fixes branch April 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants