deprecated named imports #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyanovk
force-pushed
the
deprecated_named_imports
branch
4 times, most recently
from
b131f6b to
1265610
Compare
AlexMost
reviewed
Jul 3, 2023
lib/rules/import.js
Outdated
| .map((module) => module.value.name); | ||
|
|
||
| imports | ||
| .filter((imp) => imp.check(requireArg.value, new Set(namedImports))) |
There was a problem hiding this comment.
creating Set from array is O(n) operation, better to use it outside of the filter func
AlexMost
reviewed
Jul 3, 2023
lib/rules/import.js
Outdated
| imports | ||
| .filter((imp) => imp.check(importPath)) | ||
| .filter((imp) => imp.check(importPath, new Set(importedModules))) |
There was a problem hiding this comment.
creating Set from array is O(n) operation, better to use it outside of the filter func
AlexMost
reviewed
Jul 3, 2023
tests/rules/test_import.js
Outdated
| code: 'const redirect = require("gatsby").redirect', | ||
| parser: 'babel-eslint', | ||
| options: [{ module: 'gatsby', name: 'navigate', use: 'utils/navigate' }], | ||
| errors: [{ |
There was a problem hiding this comment.
Does this error make sense here? Error cases must be inside the invalid section
stoyanovk
force-pushed
the
deprecated_named_imports
branch
from
1265610 to
bc65942
Compare
|
Thanks a lot, this PR fixes this issue - #16 |
|
the new minor version is available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.