New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rwlock #5

Merged

WieslerAA merged 10 commits into main from rwlock

Feb 12, 2025

Contributor

WieslerAA commented Feb 10, 2025

No description provided.

WieslerAA commented

View reviewed changes

src/mutex.rs Outdated Show resolved Hide resolved

WieslerAA commented

View reviewed changes

src/level.rs Outdated Show resolved Hide resolved

WieslerAA force-pushed the rwlock branch from 91da4d2 to 9474502 Compare

February 10, 2025 11:37

dkellner reviewed

View reviewed changes

src/rwlock.rs Outdated Show resolved Hide resolved

dkellner reviewed

View reviewed changes

src/rwlock.rs Outdated Show resolved Hide resolved

dkellner reviewed

View reviewed changes

src/rwlock.rs Outdated Show resolved Hide resolved

dkellner reviewed

View reviewed changes

src/rwlock.rs Outdated Show resolved Hide resolved

Contributor

dkellner commented Feb 10, 2025

I did not have time to look into it properly yet, some high-level comments:

Factoring out the lock level is nice.
There are no tests for RwLock yet, do you plan to add some?
You can merge the chore commits already if you want.

WieslerAA added 2 commits

February 10, 2025 14:16


          chore: Gitignore

a8743c8


          chore: Run clippy also on the release profile

5d373ff

WieslerAA force-pushed the rwlock branch 3 times, most recently from e7002b3 to ed1bf7e Compare

February 10, 2025 13:28

dkellner reviewed

View reviewed changes

src/mutex.rs Outdated Show resolved Hide resolved

WieslerAA force-pushed the rwlock branch from ed1bf7e to 639f273 Compare

February 10, 2025 14:45

dkellner reviewed

View reviewed changes

src/level.rs Outdated Show resolved Hide resolved

WieslerAA force-pushed the rwlock branch from 02c8421 to eab9381 Compare

February 11, 2025 11:11

Contributor

dkellner commented Feb 12, 2025

Regarding the auto-generated changelog you might want to rewrite some of the commit messages to use refactor: instead of fix:. The latter will be in the "Fixed" section of the changelog, and "Refactor lock level mechanism to new struct" or "Unify tests" probably should not show up there.

dkellner reviewed

View reviewed changes

src/rwlock.rs Outdated Show resolved Hide resolved

dkellner reviewed

View reviewed changes

src/mutex.rs Outdated Show resolved Hide resolved

Contributor

pacman82 commented Feb 12, 2025

Regarding the auto-generated changelog you might want to rewrite some of the commit messages to use refactor: instead of fix:. The latter will be in the "Fixed" section of the changelog, and "Refactor lock level mechanism to new struct" or "Unify tests" probably should not show up there.

Alternatively you may edit the change log in the Release PR

WieslerAA added 8 commits

February 12, 2025 11:30


          refactor: Lock level mechanism to new struct

a0d7109


          feat: Add Mutex::get_mut

fb782a9


          refactor: Mutex to separate module


          feat: Add RwLock

255817b


          refactor: Unify tests

bd85d74


          feat: Debug and Display for all Guards

9b4e36b


          feat: Remove escape hatch caused by returning the inner RwLock Guard …

0ecc83f

…on poisoned


          test: Multithreaded tests

7227e1a

WieslerAA force-pushed the rwlock branch from 6896275 to 7227e1a Compare

February 12, 2025 10:30

WieslerAA merged commit 18f8c30 into main

2 checks passed

WieslerAA deleted the rwlock branch

February 12, 2025 10:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet