Fix out of bounds bug #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix another issue I found where one line trees had the function below as child even though they are not related
|
Ohoh! We need a test! :) |
Changed `testHardestCall` as the file was modified in another PR
|
I've added one and changed another one due to the changes in the test file being done on another PR |
guillep
reviewed
Jun 27, 2024
Comment on lines
+76
to
+80
| ((self percentageOf: aNodeIndex) | ||
| = (self percentageOf: aNodeIndex + 1) and: [ | ||
| ((self readLine: aNodeIndex + 1) findString: '[') = 0 ]) ifTrue: [ | ||
| everyChildren add: aNodeIndex + 1. | ||
| ^ everyChildren ]. |
There was a problem hiding this comment.
We should sit and pair a bit on this code ^^
guillep
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5, now if the
NodeIndex + 1is out of bounds, the parent has no childFix another issue I found where one line trees had the function below as child even though they are not related
For example, in this case
nmi_cpu_backtracewould have been considered as the child ofghes_notify_nmibut they clearly are not (at least in this case) related