Mypy #217
Merged
Mypy #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+9
to
14
| def max_ladeleistung_w_field(default: Optional[float] = None) -> Optional[float]: | ||
| return Field( | ||
| default, | ||
| default=default, | ||
| gt=0, | ||
| description="An integer representing the charging power of the battery in watts.", | ||
| ) |
There was a problem hiding this comment.
I'm not familiar with pydantic, but shouldn't the return type hint be Field?
There was a problem hiding this comment.
Field is actually a function but it returns a FieldInfo. The type annotation for the Field function however is Any as return type as it is assigned to the pydantic model field (with a user type like Optional[float]). Therefore this type hint cheats a bit in the way similar as it's done with the deap.creator.Individual -> list[int].
|
id like to merge this next before it got hit by the very large PR #220 |
6 tasks
* Add to pre-commit (currently installs own deps, could maybe changed to poetry venv in the future to reuse environment and don't need duplicated types deps). * Add type hints.
NormannK
reviewed
Nov 26, 2024
NormannK
reviewed
Nov 26, 2024
drbacke
pushed a commit
that referenced
this pull request
Jan 1, 2025
Lasall
added a commit
that referenced
this pull request
Jan 1, 2025
Lasall
added a commit
that referenced
this pull request
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mypy support:
In second commit:
Remarks: