refactor: improve error message when header types differ #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/test-header-diff-type
branch
from
f0b94ea to
91debd1
Compare
tvainika
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connector is expecting record headers to be of the same type. This type is used to define the headers map type for the output schema.
The current workaround is to force the same type via converters, e.g. using header converter:
StringConverterinstead ofSimpleHeaderConverterthat tries to infer the type from the value.There's still another scenario that may cause issues where first record does not have headers but other records may have. This requires further investigation. See Aiven-Open/gcs-connector-for-apache-kafka#347 (comment) and #227