use singleton ObjectMapper #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
reviewed
Nov 22, 2023
...ain/java/io/aiven/kafka/connect/common/output/jsonwriter/AbstractJsonOutputStreamWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/common/output/jsonwriter/ObjectMapperProvider.java
Outdated
Show resolved
Hide resolved
|
|
||
| class KeyBuilder implements OutputFieldBuilder { | ||
|
|
||
| private final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
mental note; changing from plain object mapper to one with a exact big decimal. I don't think it may be relevant unless record.key() contains an object with big decimal values
|
|
||
| class ValueBuilder implements OutputFieldBuilder { | ||
|
|
||
| private final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
same mental note as for KeyBuilder
Reduces some memory footprint as single reused object mapper is used instead of creating new for each output stream, key, header and value serializer.
jjaakola-aiven
force-pushed
the
jjaakola-aiven-use-singleton-objectmapper
branch
from
6ffe433 to
b29c779
Compare
snuyanzin
reviewed
Nov 22, 2023
src/main/java/io/aiven/kafka/connect/common/output/jsonwriter/ObjectMapperProvider.java
Show resolved
Hide resolved
jeqo
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some memory footprint as single reused object mapper is used instead of creating new for each output stream, key, header and value serializer.