Skip to content

issues Search Results · repo:AgroCares/soilptf language:R

Filter by

18 results
 (82 ms)

18 results

inAgroCares/soilptf (press backspace or delete to remove)

AgroCares/soilptf
sptf_whc12 may not be using the ptf the description says it uses

The function description says it Calculate the water holding capacity given the pedotransferfunction of Rawls Brakensiek 1985 But the only calculation done in the code is: https://github.com/AgroCares/soilptf/blob/f352233e9a19cce7f0cf94d14cea62271dd70117/R/whc.R#L610-L662 ...
  • BrentWHR
  • 1
  • Opened 
    on May 4, 2023
  • #32

AgroCares/soilptf
replace all A_CACO3_MI with A_CACO3_IF

A_CACO3_MI is outdated and has been updated to A_CACO3_IF in pandex. Please, update all functions, and package tables for that.
  • gerardhros
  • 1
  • Opened 
    on Apr 29, 2023
  • #30

AgroCares/soilptf
sptf_cdec2 only accepts one year?

https://github.com/AgroCares/soilptf/blob/ec8fc52b151c64a31e7dc804b8deb3651c6c4ab2/R/decomposition.R#L53
  • JobdePater
  • 1
  • Opened 
    on Apr 28, 2023
  • #26

AgroCares/soilptf
Decomposition returns negative values

the functions for the decomposition returns negative values. Should nt that be positive values for decomposition (and negative values for soil carbon build up)? https://github.com/AgroCares/soilptf/blob/main/R/decomposition.R ...
  • JobdePater
  • 1
  • Opened 
    on Apr 28, 2023
  • #25

AgroCares/soilptf
input of length>1 is not accepted for B_SOILCLASS_USDA?

https://github.com/AgroCares/soilptf/blob/ec8fc52b151c64a31e7dc804b8deb3651c6c4ab2/R/cec.R#L3320
  • JobdePater
  • 2
  • Opened 
    on Apr 28, 2023
  • #24

AgroCares/soilptf
add possible options

https://github.com/AgroCares/soilptf/blob/ec8fc52b151c64a31e7dc804b8deb3651c6c4ab2/R/cec.R#L1099 c( alfisol , andisol , aridisol , entisol , gelisol , inceptisol , mollisol , oxisol , spodosol , ultisol ...
  • JobdePater
  • 1
  • Opened 
    on Apr 28, 2023
  • #23

AgroCares/soilptf
check if output of functions meet the pandex min max values

Output of the functions sometimes gives results outside the min-max range. Eg a CEC of -13 is not possible. This should be solved within the function. so before returning the output check if it fits in ...
  • JobdePater
  • 1
  • Opened 
    on Apr 28, 2023
  • #22

AgroCares/soilptf
missing CITATION file

The package doesn t yet have a CITATION file which can be initialised with usethis::use_citation() and gives more control to the output of a citation( soilptf ) call than what this call currently returns ...
  • BrentWHR
  • 1
  • Opened 
    on Apr 25, 2023
  • #20

AgroCares/soilptf
precision of sand+clay+silt <= 100

With checkmate, it is checked if the sum of 3 texture (sand+clay+silt) is equal or smaller than 100. Sometimes, when sum exceeds 100 very very slightly, it gives error. https://github.com/AgroCares/soilptf/blob/cb6c771cdc1b0cb1ecd48e2755d92130266fd248/R/bulkdensity.R#L5117 ...
  • yuki-nmi
  • Opened 
    on Apr 24, 2023
  • #18

AgroCares/soilptf
rm mp_wp = 1500 in fucntion input

  • JobdePater
  • Opened 
    on Mar 31, 2023
  • #15
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub