Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace between code and agile comment was still there when run project cleanup #25

Closed
Pnalson opened this issue May 17, 2018 · 7 comments
Labels
Milestone

Comments

@Pnalson
Copy link

Pnalson commented May 17, 2018

I noticed that AgileReview 0.9.2 add a whitespace between code and agile comment, but when I run the project cleanup the whiteapace was still there.

@maybeec
Copy link
Member

maybeec commented May 17, 2018

Hi, can you provide an example?

@Pnalson
Copy link
Author

Pnalson commented May 18, 2018

  1. origin review file
    image

  2. add a comment
    image

3.run project cleanup
image

  1. the added whitespace still there
    image

@Pnalson
Copy link
Author

Pnalson commented May 18, 2018

image

@maybeec
Copy link
Member

maybeec commented May 18, 2018

👍 thanks. We will have a look at it. However, my time is very very limited until end of June.
So maybe one of my colleagues can help here.

@maybeec maybeec added bug and removed in review labels May 18, 2018
@postmann
Copy link
Member

@Pnalson, can you check if my commit fixed the issue? Just use http://www.agilereview.org/development_update to install from our CI build.

@Pnalson
Copy link
Author

Pnalson commented Jun 7, 2018

@postmann ,I have checked this bug after your commit。
image

I have noticed that whitespaces before comments all could be deleted,becase you use “\s+”,But when add a comment agilereview just add one whitesace, this could change the origin reviewed files.
Why not just delet the one whitespace added befor a comment.

@postmann postmann added this to the 0.9.3 milestone Jun 7, 2018
@postmann
Copy link
Member

postmann commented Jun 7, 2018

Great, I'll release v0.9.3 once #26 is fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants