Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in files with user defined file extensions not working properly #18

Open
tobiasd123 opened this issue Feb 11, 2016 · 4 comments
Assignees
Labels

Comments

@tobiasd123
Copy link

Hi,
we use source files with the extension *.inl for inline methods in C/C++.

The user defined file extension is configured in Eclipse under Preferences / C/C++ / File Types
as "*.inl" "C++ source file".

If I want to add a comment within any .inl file a new Agile Review comment is added in the summary.
The *.inl file is listed in the Review tree.
The comment is written to the xml file.
But the location is not marked in the *.inl file itself.
Also the are no markers shown in the editor.

I know this might be a special case but it would help us a lot to optimize our review process with this great plugin.

Regards,
Tobias

@tobiasd123
Copy link
Author

Used version:
Eclipse IDE for C/C++ Developers
Version: Luna Release (4.4.2) 64bit
Build id: 4.4.2.M20150204-1700
AgileReview Plug-in: 0.9.1

@postmann
Copy link
Member

Hi,

I checked with my Eclipse. I installed the CDT-Features a while ago and adding comments to ini-Files works fine for me:
image

I will check with Eclipse for C/C++ Developers on the weekend, if I find some sparetime. Maybe it works for me, because I use Eclipse Classic with installed CDT. You never know :)

There's another problem, I see with ini-Files:
Comments in ini-Files have to be on separate lines (see Wikipedia), but AgileReview adds comments at the end of the commented line. This would actually change the value for the commented key.
For ini-Files and those with similar syntaxes we would have to implement a special handling (meaning "add a line before and after the commented line").

Nevertheless, this seems to be a quite nice feature.

@may-bee: what do you think about it?

Regards,
Peter

@postmann postmann changed the title Comments in files with user defined file extensions no working proper Comments in files with user defined file extensions not working properly Feb 14, 2016
@postmann
Copy link
Member

Okay, downloaded Eclipse for C/C++ Developers and was able to reproduce the issue. Going to check what's causing the issue.

@postmann
Copy link
Member

@tobiasd123, just for you to know that you weren't forgotten: I'm still struggeling while trying to debug into this issue. The plugin configurations when launching my dev instance of Eclipse is never quite the same as when using the CDT-only Eclipse...

@postmann postmann added the bug label May 16, 2016
@postmann postmann self-assigned this May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants