Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Details and Comment Details in different views #4

Closed
ghost opened this issue Feb 14, 2018 · 8 comments
Closed

Review Details and Comment Details in different views #4

ghost opened this issue Feb 14, 2018 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 14, 2018

Is it possible to show the Review Details and Comment Details in different views so that it is shown at the same time? At the moment the Review Details and Comment Details are shown in the same view by clicking on a review or comment.

Thank you, regards

@maybeec
Copy link
Member

maybeec commented Feb 14, 2018

Hi, no this is not possible currently. We decided to have both detail views in one to not overload the user with multple views to be managed.

@biancode
Copy link

biancode commented Mar 1, 2018

Hi Malte,

I'm sorry, but it's not easy to work with this changing view when you're mainly using the keyboard.

cya
Klaus

@maybeec
Copy link
Member

maybeec commented Mar 1, 2018

Thanks for the Feedback @biancode .
Can you scatch two to three workflows you would like to navigate through with the keyboard?
Maybe we can adress it, if we get to know what your common navigation is about.

@biancode
Copy link

biancode commented Mar 1, 2018

Yes, we could do that. Another problem is our Eclipse - NaturalOne (SAG). It includes some Plugins, which catches the focus and so everytime we switch to the Review Explorer View. That brings the comment detail view back to the review detail view. That problem will occure with every PlugIn, which sets the focus to the Workbench of Eclipse.

@maybeec
Copy link
Member

maybeec commented Mar 1, 2018

Ok, so by having two seperate views, we would get rid of the unintended switching between the views. Makes. sense.

@biancode
Copy link

biancode commented Mar 1, 2018

Xtext and LaTeX should get the same trouble, because they compile every change/save too and that brings the console view of Eclipse in front and boom - focus is lost and views will change from comment to review

@maybeec
Copy link
Member

maybeec commented Mar 1, 2018

You are right, I created a new issue in the right repository. Lets continue tracking and further discussion there.

AgileReview-Project/AgileReview-Legacy-Plugin#23

@maybeec maybeec closed this as completed Mar 1, 2018
@biancode
Copy link

biancode commented Mar 1, 2018

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants