Skip to content

Commit

Permalink
Move EC_Script to TundraCore. EC_Script is core functionality and scr…
Browse files Browse the repository at this point in the history
…ipting language agnostic. Closes realXtend#763.
  • Loading branch information
Stinkfist0 committed Sep 27, 2014
1 parent 71ba4ee commit 68d83a0
Show file tree
Hide file tree
Showing 11 changed files with 7 additions and 31 deletions.
1 change: 0 additions & 1 deletion CMakeBuildConfigTemplate.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ AddEntityComponent(EC_TransformGizmo)

## Here are the Application level ECs that wont be added if BUILD_SDK_ONLY is TRUE (default is FALSE)
if (NOT BUILD_SDK_ONLY)
AddEntityComponent(EC_Script) # Optional but used by both PythonScriptModule and JavascriptModule.
AddEntityComponent(EC_PlanarMirror)
AddEntityComponent(EC_ProximityTrigger)
AddEntityComponent(EC_LaserPointer)
Expand Down
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ macro(UseTundraCore)
include_directories(${PROJECT_BINARY_DIR}/src/Core/TundraCore/Framework)
include_directories(${PROJECT_BINARY_DIR}/src/Core/TundraCore/Input)
include_directories(${PROJECT_BINARY_DIR}/src/Core/TundraCore/Scene)
include_directories(${PROJECT_BINARY_DIR}/src/Core/TundraCore/Script)
include_directories(${PROJECT_BINARY_DIR}/src/Core/TundraCore/Ui)
endmacro()

Expand Down
1 change: 0 additions & 1 deletion src/Application/JavascriptModule/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ link_package(QT4)
link_ogre()
link_boost()
link_modules(TundraCore Math TundraProtocolModule)
link_entity_components(EC_Script)

SetupCompileFlagsWithPCH()

Expand Down
6 changes: 4 additions & 2 deletions src/Core/TundraCore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ file(GLOB MOC_FILES
Input/InputAPI.h Input/InputContext.h Input/KeyEvent.h Input/KeyEventSignal.h Input/MouseEvent.h
Input/GestureEvent.h Input/EC_InputMapper.h
Scene/SceneAPI.h Scene/Scene.h Scene/Entity.h Scene/IComponent.h Scene/EntityAction.h
Scene/EC_Name.h Scene/EC_DynamicComponent.h Scene/AttributeChangeType.h Scene/ChangeRequest.h
Scene/EC_PlaceholderComponent.h
Scene/AttributeChangeType.h Scene/ChangeRequest.h Scene/EC_*.h
Ui/UiAPI.h Ui/UiGraphicsView.h Ui/UiMainWindow.h Ui/UiProxyWidget.h Ui/QtUiAsset.h Ui/RedirectedPaintWidget.h
Script/EC_Script.h Script/IScriptInstance.h Script/ScriptAsset.h
)

AddSourceFolder(Asset)
Expand All @@ -33,6 +33,7 @@ AddSourceFolder(Console)
AddSourceFolder(Framework)
AddSourceFolder(Input)
AddSourceFolder(Scene)
AddSourceFolder(Script)
AddSourceFolder(Ui)

set(SOURCE_FILES ${CPP_FILES} ${H_FILES})
Expand Down Expand Up @@ -74,3 +75,4 @@ final_target()

# Declare Windows core dependencies
setup_install_windows_deps ("qjson.dll" Release|RelWithDebInfo|Debug)

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// For conditions of distribution and use, see copyright notice in LICENSE

#include "StableHeaders.h"
#include "DebugOperatorNew.h"

#include "EC_Script.h"
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// For conditions of distribution and use, see copyright notice in LICENSE

#include "StableHeaders.h"
#include "DebugOperatorNew.h"

#include "ScriptAsset.h"
Expand Down
File renamed without changes.
27 changes: 0 additions & 27 deletions src/EntityComponents/EC_Script/CMakeLists.txt

This file was deleted.

1 comment on commit 68d83a0

@jonnenauha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw i noticed script panel in profiler is broken. Says the EC is disabled in the build.

#ifdef EC_Script_ENABLED
#include "IScriptInstance.h"
#include "EC_Script.h"
#endif

This probably broke and that macro no longer evaluates to true? I can just include it as part of core?

Please sign in to comment.