Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NotImplementedError in download_dataset #22

Merged
merged 1 commit into from
Jul 14, 2024
Merged

fix: NotImplementedError in download_dataset #22

merged 1 commit into from
Jul 14, 2024

Conversation

yumemio
Copy link
Contributor

@yumemio yumemio commented Jun 11, 2024 •
edited
Loading

Summary 📝

Fixes the issue of download_dataset raising NotImplementedError even if a correct dataset name is specified.

Details

  1. pip install kan_gpt
  2. Download a dataset: 
    $ python3 -m kan_gpt.download_dataset --dataset tinyshakespeare
  3. Old behavior: raises NotImplementedError after downloading the dataset
  4. New behavior: the script exits without throwing the error

Checks

  • Closed #798
  • Tested Changes
  • Shakespeare Approval

Thanks for reviewing!

@AdityaNG AdityaNG merged commit 31ad768 into AdityaNG:main Jul 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yumemio @AdityaNG