[trello.com/c/Aw0Vfnmd] {Secret wallets} UI: Show Transactions 🔐 1️⃣ #741
+86
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
force-pushed
the
trello.com/c/Aw0Vfnmd
branch
from
cad7f7a to
6671870
Compare
Lainaaa
changed the title
art-divin
reviewed
Mar 23, 2025
| @@ -114,7 +117,7 @@ class TransactionsListViewControllerBase: UIViewController { | |||
| super.viewDidLoad() | |||
|
|
|||
| navigationItem.largeTitleDisplayMode = .never | |||
| navigationItem.title = String.adamant.transactionList.title | |||
| navigationItem.title = String.adamant.transactionList.title + (secretWalletsViewModel.state.currentWallet?.name ?? "") | |||
There was a problem hiding this comment.
Nit: you might want to consider to have an extension on secretWalletsViewModel.state which would return currentWalletName to simplify code here
There was a problem hiding this comment.
In the next iterations I plan to bring everything to the same form
There was a problem hiding this comment.
But before, this and "send screen" should be merged
art-divin
reviewed
Mar 23, 2025
art-divin
approved these changes
Mar 23, 2025
Lainaaa
force-pushed
the
trello.com/c/Aw0Vfnmd
branch
from
4f2d7b7 to
2472613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.