[1]Tried to Eliminate the need for Copy in the used types #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davids91
force-pushed
the
feature/no-copy
branch
4 times, most recently
from
d643802 to
db9cda9
Compare
davids91
commented
Apr 26, 2023
src/node.rs
Outdated
Comment on lines
179
to
180
| // move current data to appropriate child ??? | ||
| let data = std::mem::replace(&mut self.ty, NodeType::Internal); |
There was a problem hiding this comment.
Here I have had the understanding that whenever a Leaf node is "promoted" to an internal or simplified Node ( not sure which tbh ), its data will be moved to the child where most appropriate; I just don't understand which child may that be?
Or the data is supposed to be duplicated at this time?
There was a problem hiding this comment.
oh I think I got why copy is needed
davids91
force-pushed
the
feature/no-copy
branch
from
db9cda9 to
69715ab
Compare
davids91
changed the title
davids91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to eliminate the Copy requirement from the Node, but realized it is required for the LOD logic of it all.. I did some minor changes anyway, I hope you'll see those as improvements nonetheless!