Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Webpack Migration #226

Closed
wants to merge 105 commits into from
Closed

[WIP] Webpack Migration #226

wants to merge 105 commits into from

Conversation

gavinhenderson
Copy link
Member

@gavinhenderson gavinhenderson commented May 11, 2020

Pages Migrated

  • Intro
  • Help
  • Edit Config (in progress)
  • Quick Setup
  • Main (index)

New NPM scripts:

webpack:dev - Runs webpack-dev-server and opens app in the browser
webpack:build - Builds the webpack app to the dist folder
webpack:cordova-dev - Opens a simulator and runs the webpack app in it (includes hot reloading)
webpack:cordova-build - Builds the webpack app into the cordova folder

test - Runs jest tests
test:watch - Runs the tests in watch mode
test:coverage - Outputs the test coverage

Config

There is a webpack folder that contains all the config files for webpack. HtmlWebpackPlugin is used to copy the HTML pages into the build and then we give each file one chunk. It might make sense eventually to have a main chunk and include that in all pages.

How to help

Start migrating a page and submit a PR. I will make sure to keep this branch up to date with master, so if you make improvements to the master ill make sure they end up on this branch.

Another great way to contribute would be to add some tests! 👍

Any questions or comments dont hesitate to reach out :)

@gavinhenderson
Copy link
Member Author

Going to close this.

It was to ambitious. Whatever we do we will need to do it incrementally and not big bang. The code is still accessible for inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants