-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Webpack Migration #226
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to close this. It was to ambitious. Whatever we do we will need to do it incrementally and not big bang. The code is still accessible for inspiration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages Migrated
New NPM scripts:
webpack:dev
- Runs webpack-dev-server and opens app in the browserwebpack:build
- Builds the webpack app to thedist
folderwebpack:cordova-dev
- Opens a simulator and runs the webpack app in it (includes hot reloading)webpack:cordova-build
- Builds the webpack app into the cordova foldertest
- Runs jest teststest:watch
- Runs the tests in watch modetest:coverage
- Outputs the test coverageConfig
There is a
webpack
folder that contains all the config files for webpack.HtmlWebpackPlugin
is used to copy the HTML pages into the build and then we give each file one chunk. It might make sense eventually to have a main chunk and include that in all pages.How to help
Start migrating a page and submit a PR. I will make sure to keep this branch up to date with master, so if you make improvements to the master ill make sure they end up on this branch.
Another great way to contribute would be to add some tests! 👍
Any questions or comments dont hesitate to reach out :)