Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put space into the prediction for word prediction. #284

Open
willwade opened this issue Sep 29, 2022 · 2 comments
Open

Put space into the prediction for word prediction. #284

willwade opened this issue Sep 29, 2022 · 2 comments

Comments

@willwade
Copy link
Collaborator

Right now if you spell a word - say "If" - space doesn't come up - until right at the end. But it should start to see that as a next "letter" and move that higher up the list

@gavinhenderson
Copy link
Member

@willwade So I sort of managed to achieve this by shifting the default vocab about.

I moved the Space to the top of the I will spell it branch. This meant that it will always be at the top of the branch. Granted, its not a smart or context aware solution but it does mean that if a user types if they dont have to go to the bottom to get space. But in turn it adds one extra down click (or scan) to get past the space key if we force it to the top.

The options I see going forward are:

A) Nothing
B) Update the docs to show this trick so that a judgement can be made about each individual and what is best for them
C) Change the default vocab to have the space at the top
D) Keep this issue and come up with a 'smart' way to only sometimes show the Space command. This would involve some tinkering with the prediction engine.

@willwade What do you think the best option is? I would lean towards C or B but its your call.

Details

The default vocab is:

# I will spell it <meta data-spell-branch="" data-spell-update-dyn-onchange="">

##  <meta data-dyn="spell-word-prediction" data-words-file="Spell_Prediction/bncfrequency.json" data-max-nodes="3" data-predict-after-n-chars="3">

##  <meta data-dyn="spell-letter-prediction" data-words-file="Spell_Prediction/bncfrequency.json">

## Space <meta data-spell-letter=" ">

## Undo <meta data-spell-delchar="">

## Finish <meta data-spell-finish="">

I changed it to:

# I will spell it <meta data-spell-branch="" data-spell-update-dyn-onchange="">

##  <meta data-dyn="spell-word-prediction" data-words-file="Spell_Prediction/bncfrequency.json" data-max-nodes="3" data-predict-after-n-chars="3">

##  <meta data-dyn="spell-letter-prediction" data-words-file="Spell_Prediction/bncfrequency.json">

## Space <meta data-spell-letter=" ">

## Undo <meta data-spell-delchar="">

## Finish <meta data-spell-finish="">

@gavinhenderson
Copy link
Member

After discussion we will go with option C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants