-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gulp JS to fix Favicons Task #34
Comments
Summary of Google Favicon Docs:
In the TLRD portal, multiple .ico were uploaded in the preheader + miscellaneous places in the portal. I deleted all the old .ico files and their links. As long as we only have one .ico file in the homepage header, it'll be picked up. After cleaning up the old files, I added the favicon in DNN admin toolbar: Settings > Site Settings > Logos and Icons. I then requested a reindex of the homepage in GSC, and the new logo showed up a few days later. |
The wording is a little confusing, the second bullet: how can there be more than one file named For the second bullet, is it ONLY the home page? Do you get demerits if its on all pages of the site? |
Edit: We found out why the |
The solution used the 'nvm run favicon' (not the way I did it on TLRD). We've fixed a file that outputs the icon paths. The icon is now loading correctly in the homepage's page source, and I have requested that Google reindex the homepage. |
When we
npm run favicons
, there are now two things that need fixing:npm run favicons
is updated to replace the default DNN favicon.ico in the site root (the original that worked in browsers back in the 1990s) with the appropriate generated one for this client/project. This will likely be a solid fallback in case something goes wrong over time with the <link ...> one.** @nacho fixed this on TLRD, so we need to get those details from him. I believe after 3 or 4 guesses, he determined which file the Google Search Result listings actually use for the icon (see pic below showing the DNN icon on PDPR).
Here are Googles docs on this: Define a favicon to show in search results
The text was updated successfully, but these errors were encountered: