ADG-414 Improve code quality with github actions #415
Conversation
✅ Deploy Preview for accessibility-developer-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudigier
changed the title
.github/workflows/codeQuality.yml
Outdated
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
@rudigier, shouldn't this be main?
.github/workflows/codeQuality.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| # | |||
| # linter and dependancy cruiser tests | |||
There was a problem hiding this comment.
What is dependancy cruiser?
|
Wow, that was quick! Could we run the fix jobs and commit the changes in this workflow? I don't see any upside in still having to do this locally. |
|
@backflip: pr bitte nochmals reviewen |
This reverts commit ced38f0.
|
@backflip Switched to checking instead of auto-fixing to avoid unexpected commits in PRs. Developers should review and apply fixes manually. |
|
@rudigier, hm, but isn't this worse than the current setup? Assuming I want to contribute to the project, I will only be informed after opening a PR that I need to reformat some files. With the current setup this already happens before committing. I would prefer to close this PR if we cannot auto-fix. WDYT? |
No description provided.