Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spline.pluginsEnabledByDefault property #759

Closed
wants to merge 2 commits into from

Conversation

martinf-moodys
Copy link
Contributor

@martinf-moodys martinf-moodys commented Oct 24, 2023

This new property aims to fix a performance issue when scanning plugins via ClassGraph during Spline initialization.
This may take up to 30 seconds to call ClassGraph.scan from AutoDiscoveryPluginRegistry. By default, the property is set to true to keep the current behavior.

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wajda
Copy link
Contributor

wajda commented Jul 9, 2024

I somehow missed this PR, sorry.
That's a good idea, but it contains a couple of things I'm not sure about. Let me review the PR thoroughly.

Copy link

Copy link

sonarqubecloud bot commented Jan 2, 2025

@wajda wajda changed the title New spline.pluginsEnabledByDefault property New spline.pluginsEnabledByDefault property Jan 6, 2025
@wajda wajda mentioned this pull request Jan 7, 2025
@wajda
Copy link
Contributor

wajda commented Jan 7, 2025

This PR with slight changes is incorporated into #854

@wajda wajda closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants